Add codesign for macos build #7971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code signing for MacOS build.
The sign message which includes the Signer's Identity is to be passed via environment variable during the build process.
The final dmg created after code signing works well on earlier version of MacOS without issues. However, for the newer version of the macos, to pass through the gatekeeper, the DMG and included executables needs to be notarized using notary tool. At the moment, the notarization is not passing yet.
The fix for notarization is outside the scope of this PR. That will be addressed as part of the build script pipeline in Jenkins as notarization can take up to 30 mins to complete and requires setting up key profiles.