Add math.inf to all_time_ratio calculation
#7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
kozlovsky
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Interestingly, the JSON standard does not allow Infinity or NaN values, but Python extends the format by including them: https://docs.python.org/3/library/json.html#infinite-and-nan-number-values.
As Tribler GUI and Core are both in Python, it should be fine.
| return 0 | ||
|
|
||
| if not self.all_time_download: | ||
| return 0 if not self.all_time_upload else float("inf") |
There was a problem hiding this comment.
nitpick: I slightly prefer math.inf to float("inf"), but both are possible.
drew2a
changed the title
float('inf') to all_time_ratio calculationmath.inf to all_time_ratio calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7865 by adding
math.infto theall_time_ratioformula.