Fix the issue of passing the URL in bytes to the get_metainfo function.
#7848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Jan 24, 2024
- Refactored the `get_metainfo` function in `DownloadManager` class to change the type of the `url` parameter from `Optional[Union[str, bytes]]` to `Optional[str]`. - Added a new test case `test_get_torrentinfo_get_metainfo_from_downloaded_magnet` in the file `test_torrentinfo_endpoint.py`. This test case checks if the correct arguments are passed to the `get_metainfo` function when retrieving metainfo from a downloaded magnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7823
The actual fix is encapsulated in the following line:
The remainder of the PR focuses on testing the new change and simplifying the
get_torrent_infofunction, which was also part of the testing process.