Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for recursive_unicode function #7845

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jan 23, 2024

While working on #7823 I became suspicious that recursive_unicode was not functioning correctly. To confirm this, I wrote tests and found that the function works as expected. This PR includes these tests.

@drew2a drew2a marked this pull request as ready for review January 23, 2024 07:52
@drew2a drew2a requested review from a team and egbertbouman and removed request for a team January 23, 2024 07:52
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Although it would be nice to also test if UnicodeDecodeError is being handled as expected.

@drew2a drew2a force-pushed the refactoring/unicode branch from fc9e9e9 to 9cae450 Compare January 23, 2024 14:01
@drew2a drew2a force-pushed the refactoring/unicode branch from 9cae450 to 2c881cf Compare January 23, 2024 14:01
@drew2a
Copy link
Contributor Author

drew2a commented Jan 23, 2024

@egbertbouman tested 👍

@drew2a drew2a requested a review from egbertbouman January 23, 2024 14:57
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drew2a drew2a merged commit 7ca5ecc into Tribler:main Jan 23, 2024
20 checks passed
@drew2a drew2a deleted the refactoring/unicode branch January 23, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants