Refactor magnet link parsing logic and add new test cases #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
refactoring/parse_magnetlink
branch
2 times, most recently
from
04c3966 to
2d60398
Compare
drew2a
requested review from
a team and
egbertbouman
and removed request for
a team
src/tribler/core/components/libtorrent/download_manager/download_manager.py
Show resolved
Hide resolved
src/tribler/core/components/libtorrent/restapi/torrentinfo_endpoint.py
Outdated
Show resolved
Hide resolved
src/tribler/core/components/libtorrent/restapi/torrentinfo_endpoint.py
Outdated
Show resolved
Hide resolved
egbertbouman
approved these changes
Jan 15, 2024
drew2a
force-pushed
the
refactoring/parse_magnetlink
branch
from
8040ba5 to
73bb8ac
Compare
- Refactored the `parse_magnetlink` function to use `libtorrent.parse_magnet_uri` for parsing magnet links. - Added a new test case for parsing a magnet link with a wrong hash. - Added a new test case for parsing a magnet link with bytes input. - Removed two existing test cases that were testing invalid infohashes, as they are no longer needed.
drew2a
force-pushed
the
refactoring/parse_magnetlink
branch
from
73bb8ac to
ba9582e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
parse_magnetlinkfunction to uselibtorrent.parse_magnet_urifor parsing magnet links, as it seems safer and more convenient to rely on the native libtorrent parsing mechanism instead of our own.It is includes:
This refactoring was carried out during the work on: