Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylint-pytest plugin #7789

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add pylint-pytest plugin #7789

merged 1 commit into from
Jan 22, 2024

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Dec 27, 2023

This PR adds the pylint-pytest plugin to the .pylintrc file, enabling additional checkers for pytest. It also includes the pylint-pytest package in the requirements-test.txt file, ensuring it is installed when running tests.

The necessity of adding this plugin emerged from the notable discussion in #7764, where @drew2a proposed the use of pylint-pytest and @qstokkink supported the idea:

Just to repeat - myself and the docs - adding a "name" is not the only way to resolve this. Secondarily, this has nothing to do with Pylint, other than that it will also tell you the same thing. I like the idea of adding pylint-pytest though.

Ref:

@drew2a
Copy link
Contributor Author

drew2a commented Jan 2, 2024

Unfortunately, it seems not possible to use this plugin with Codacy, as they use preinstalled plugins:

@drew2a
Copy link
Contributor Author

drew2a commented Jan 2, 2024

I've created a PR to codacy-pylint-python3 to extend the plugin list:

Let's wait for the response from the repository maintainers.

@drew2a
Copy link
Contributor Author

drew2a commented Jan 12, 2024

The repository maintainers responded that the requested change was added:

@drew2a drew2a force-pushed the feature/pylint-pytest branch from 72aecd4 to f3ef2aa Compare January 17, 2024 15:04
@drew2a drew2a marked this pull request as ready for review January 17, 2024 15:06
@drew2a drew2a requested review from a team, xoriole, kozlovsky and egbertbouman and removed request for a team January 17, 2024 15:06
The commit adds the pylint-pytest plugin to the .pylintrc file, enabling additional checkers for pytest. It also includes the pylint-pytest package in the requirements-test.txt file, ensuring it is installed when running tests.
@drew2a drew2a force-pushed the feature/pylint-pytest branch from f3ef2aa to 8eacca2 Compare January 22, 2024 14:45
@drew2a drew2a merged commit 35fb3d7 into Tribler:main Jan 22, 2024
20 checks passed
@drew2a drew2a deleted the feature/pylint-pytest branch January 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants