Upload binaries by default #7680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team,
xoriole and
qstokkink
and removed request for
a team
qstokkink
approved these changes
Nov 9, 2023
xoriole
reviewed
Nov 9, 2023
I don't know. It is up to us to decide. I personally never use binaries from the PR builds.
Yes. For example, for the Windows build it adds 2m 43s: 
|
|
As an alternative approach, I could implement a condition where, if a PR has a specific label (such as 'upload binaries'), then the binaries would be uploaded. |
drew2a
force-pushed
the
feature/binaries_to_actions
branch
from
9bfe944 to
c123bee
Compare
|
I'm closing this PR. The new PR with the add binaries for PR with the label #7689. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables uploading binaries for each PR by default.