Make the libtorrent
tests more responsive
#7541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't completely solve the issue causing the flakiness of the libtorrent tests. However, the changes have made the tests more responsive and should, at the very least, prevent the main thread from freezing.
Besides minor refactoring, there are two significant changes in this PR:
An asyncio switch was added to the
wait_for_status
function due to the potential of blocking the main thread during pytest execution. To understand the possibility, consider this example:tribler/src/tribler/core/utilities/tests/test_async_force_switch.py
Lines 10 to 34 in 018cd5f
The shutdown logic has been rewritten to be slightly more accurate. While this change may not directly influence test stability, it could contribute slightly to it.
Related to #7495
Refs: