Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @pytest.mark.looptime(False) for test_channel_update_and_download #7525

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add @pytest.mark.looptime(False) for test_channel_update_and_download #7525

merged 1 commit into from
Jul 6, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jul 4, 2023

This PR fixes test_channel_update_and_download by adding @pytest.mark.looptime(False) decorator as this test depends on a real sleep.

See:

tribler/src/tribler/core/components/metadata_store/db/store.py

Lines 562 to 563 in 9bb752c

if external_thread:
sleep(self.sleep_on_external_thread)

Related to #7495

Refs:

@drew2a drew2a force-pushed the fix/test_channel_update_and_download branch from 20739a3 to 6bc3ab0 Compare July 5, 2023 13:22
@drew2a drew2a marked this pull request as ready for review July 5, 2023 13:32
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team July 5, 2023 13:32
@drew2a drew2a mentioned this pull request Jul 5, 2023
Closed
@drew2a drew2a force-pushed the fix/test_channel_update_and_download branch from a6ee4c3 to f57d0da Compare July 6, 2023 09:28
@drew2a drew2a merged commit c0330ef into Tribler:main Jul 6, 2023
@drew2a drew2a deleted the fix/test_channel_update_and_download branch July 6, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drew2a @kozlovsky