Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClientOSError as an expected exception #7507

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add ClientOSError as an expected exception #7507

merged 1 commit into from
Jun 27, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jun 27, 2023

This PR fixes the flakiness of test_aiohttp_assertion_patched from #7495
@kozlovsky please confirm that this is a proper fix.

@drew2a drew2a requested a review from kozlovsky June 27, 2023 10:43
@drew2a drew2a marked this pull request as ready for review June 27, 2023 10:43
@drew2a drew2a requested a review from a team June 27, 2023 10:43
kozlovsky
kozlovsky approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@kozlovsky kozlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drew2a it looks like a correct fix

@drew2a drew2a merged commit f1d2655 into Tribler:main Jun 27, 2023
@drew2a drew2a deleted the fix/test_aiohttp_assertion_patched branch June 27, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drew2a @kozlovsky