Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Starting <current test>...' print statement #7506

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jun 26, 2023

This PR is related to #7495 and adds print information about the name of a test before it executes. It will help to investigate errors like 'Segmentation fault' from https://github.com/Tribler/tribler/actions/runs/5378679663/jobs/9758812804?pr=7503

The output looks like:

Starting "test_modify_tags"...
src/tribler/core/components/knowledge/restapi/tests/test_knowledge_endpoint.py::test_modify_tags PASSED                           [  7%] in 0.265s (5.7s in total)
Starting "test_get_suggestions_invalid_infohash"...
src/tribler/core/components/knowledge/restapi/tests/test_knowledge_endpoint.py::test_get_suggestions_invalid_infohash PASSED      [  7%] in 0.012s (5.8s in total)
Starting "test_get_suggestions"...
src/tribler/core/components/knowledge/restapi/tests/test_knowledge_endpoint.py::test_get_suggestions PASSED                       [  7%] in 0.029s (5.8s in total)
Starting "test_shutdown"...
src/tribler/core/components/ipv8/eva/tests/test_protocol.py::test_shutdown PASSED                                                 [  7%] in 0.005s (5.8s in total)
Starting "test_on_error_correct_nonce"...
src/tribler/core/components/ipv8/eva/tests/test_protocol.py::test_on_error_correct_nonce PASSED                                   [  7%] in 0.005s (5.8s in total)

@drew2a drew2a marked this pull request as ready for review June 26, 2023 14:06
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team June 26, 2023 14:06
@drew2a
Copy link
Contributor Author

drew2a commented Jun 26, 2023

I've changed the output to this:

16:56:43.676 Starting "test_add_torrents_from_dir"...
src/tribler/core/components/metadata_store/restapi/tests/test_channels_endpoint.py::test_add_torrents_from_dir PASSED             [ 70%] in 0.234s (59 seconds in total)
16:56:43.909 Starting "test_commit_all_channels"...
src/tribler/core/components/metadata_store/restapi/tests/test_channels_endpoint.py::test_commit_all_channels PASSED               [ 70%] in 0.251s (a minute in total)
16:56:44.160 Starting "test_get_channel_contents_remote_request_timeout"...
src/tribler/core/components/metadata_store/restapi/tests/test_channels_endpoint.py::test_get_channel_contents_remote_request_timeout PASSED [ 70%] in 0.081s (a minute in total)
16:56:44.242 Starting "test_get_channel_contents_remote_request_no_peers"...
src/tribler/core/components/metadata_store/restapi/tests/test_channels_endpoint.py::test_get_channel_contents_remote_request_no_peers PASSED [ 70%] in 0.081s (a minute in total)
16:56:44.323 Starting "test_get_channels_count"...
src/tribler/core/components/metadata_store/restapi/tests/test_channels_endpoint.py::test_get_channels_count PASSED                [ 70%] in 0.079s (a minute in total)

@drew2a drew2a force-pushed the feature/print_current_test branch from 8252021 to 788adba Compare June 26, 2023 14:58
@drew2a drew2a requested a review from kozlovsky June 26, 2023 14:59
@drew2a drew2a merged commit 5be6bac into Tribler:main Jun 27, 2023
@drew2a drew2a deleted the feature/print_current_test branch June 27, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants