Shut down the Tribler Core process if the GUI process crashes. #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/core_process_termination_on_gui_crash
branch
from
5caa12e to
7cfa04f
Compare
kozlovsky
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6994 by adding
GuiProcessWatcherandGuiProcessWatcherComponent.With this PR, GUI passes an additional environment variable to Core with the PID of the GUI process. If GUI PID was passed to Core, it starts watching GUI process state with periodical checks. If the GUI process stops, the watcher calls
session.shutdown_event.set()to shut down the Core process.