Fix Tribler shutdown after closing of FeedbackDialog #6960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team,
xoriole and
drew2a
and removed request for
a team
kozlovsky
changed the title
drew2a
approved these changes
Jul 4, 2022
xoriole
approved these changes
Jul 5, 2022
|
This PR could be related to #6039 |
kozlovsky
force-pushed
the
fix/tribler_shutdown_on_error
branch
from
e63e8b9 to
554b141
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in case of exception, if SentryReporter is in test mode, after reporting an exception it calls
AppManager.quit_application(), which in turn callsQApplication.quit().This logic is incorrect, as the Tribler core process, managed by a
QProcessinstance, terminated immediately without any possibility to do cleanup work, like removing thetriblerd.lockfile or saving the libtorrent state.The correct behavior is to stop the Core process the usual way and then shut down GUI. This PR fixes the shutdown logic, allowing the Core to shut down properly.