Fix the upgrader logic if the tags db file was not created yet #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/upgrade_tags_db
branch
from
6e8104b to
2c9de1a
Compare
kozlovsky
force-pushed
the
fix/upgrade_tags_db
branch
from
2c9de1a to
92bda50
Compare
drew2a
force-pushed
the
fix/upgrade_tags_db
branch
2 times, most recently
from
701f17a to
92bda50
Compare
drew2a
approved these changes
Jun 29, 2022
| @@ -243,10 +243,12 @@ def add_column(db, table_name, column_name, column_type): | |||
|
|
|||
| self._logger.info(f'{version.current}->{version.next}') | |||
|
|
|||
| add_column(db=mds._db, table_name='ChannelNode', column_name='tag_processor_version', column_type='INT') | |||
| add_column(db=tags.instance, table_name='TorrentTagOp', column_name='auto_generated', column_type='BOOLEAN') | |||
| if tags is not None: | |||
There was a problem hiding this comment.
NIT:
Maybe (for simplifying the logic of future upgraders) we should create tags DB in the case it does not exist.
Otherwise, in every future upgrader we should use the construction that you have used above:
if tags is non None:
...There was a problem hiding this comment.
Thank you for the suggestion! I think it is better to have this check repeated in future upgrades.
Right now, the tags database does not have a version, and we rely on the metadata store version. If we create the tags database during the upgrade, it will already have the latest schema, and the subsequent upgrades should have the logic to skip the upgrade. So, creating the database in the upgrade will not reduce the number of checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6944