Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessChecker refactoring #6941

Merged
merged 1 commit into from
Jun 27, 2022
Merged

ProcessChecker refactoring #6941

merged 1 commit into from
Jun 27, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jun 20, 2022

This PR fixes #6874 by refactoring ProcessChecker implementation and adding a broad exception handling.

@drew2a drew2a marked this pull request as ready for review June 21, 2022 17:42
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team June 21, 2022 17:42
@drew2a drew2a force-pushed the main branch 2 times, most recently from 2370caf to 21168b4 Compare June 23, 2022 11:54
Copy link
Contributor

@kozlovsky kozlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring! It makes the logic much easier to understand. The logic may contain some old bugs, but this PR's goal is not to fix bugs but to clarify the logic. It becomes possible now to investigate and fix possible old bugs in subsequent PRs.

src/tribler/core/utilities/process_checker.py Outdated Show resolved Hide resolved
@drew2a drew2a force-pushed the fix/6874 branch 2 times, most recently from 94296c4 to c2e7472 Compare June 27, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[7.11.0] Various problems with triblerd.lock
2 participants