Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename QtSingleApplication.activation_window() to tribler_window #6830

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Mar 24, 2022

This is a PR with refactoring requested by @kozlovsky in #6829

@drew2a drew2a requested a review from kozlovsky March 24, 2022 12:07
@drew2a drew2a marked this pull request as ready for review March 24, 2022 12:07
@drew2a drew2a requested a review from a team March 24, 2022 12:07
@drew2a drew2a force-pushed the refactoring/activation_window branch 4 times, most recently from db43e84 to a1b98f3 Compare March 24, 2022 15:46
@drew2a drew2a force-pushed the refactoring/activation_window branch from a1b98f3 to 58c6b90 Compare March 24, 2022 15:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a
Copy link
Contributor Author

drew2a commented Mar 24, 2022

retest this please

1 similar comment
@drew2a
Copy link
Contributor Author

drew2a commented Mar 24, 2022

retest this please

@drew2a drew2a changed the title Rename QtSingleApplication.activation_window() to tribler_window WIP Rename QtSingleApplication.activation_window() to tribler_window Mar 24, 2022
@drew2a drew2a marked this pull request as draft March 24, 2022 17:28
@drew2a drew2a marked this pull request as ready for review March 24, 2022 17:39
@drew2a drew2a changed the title WIP Rename QtSingleApplication.activation_window() to tribler_window Rename QtSingleApplication.activation_window() to tribler_window Mar 24, 2022
@drew2a drew2a merged commit 710bd88 into Tribler:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants