Replace get by select.limit in BandwidthDatabase.get_latest_transaction

[drew2a]

This PR fixes #6802.

It seems possible to create a multiple transactions for the given pair or public_key_a and public_key_b by setting bandwidth_database.store_all_transactions to True:

tribler/src/tribler/core/components/bandwidth_accounting/db/transaction.py

Lines 151 to 161 in ec35106

	if not bandwidth_database.store_all_transactions:
	# Make sure to only store the latest pairwise transaction.
	for tx in cls.select(
	lambda c: c.public_key_a == transaction.public_key_a and
	c.public_key_b == transaction.public_key_b):
	tx.delete()
	db.commit()
	cls(**transaction.get_db_kwargs())
	elif not bandwidth_database.has_transaction(transaction):
	# We store all transactions and it does not exist yet - insert it.
	cls(**transaction.get_db_kwargs())

That's why BandwidthDatabase.get_latest_transaction should be ready for this situation.

[drew2a]

retest this please

[drew2a]

retest this please

[drew2a]

retest this please

[drew2a]

retest this please

[drew2a]

Unfortunately, GUI tests are dramatically unstable, so, I'm opening the PR to review as is (with the failed GUI test).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[devos50]

Thanks for fixing this! We indeed missed this case 👍 .

By default, store_all_transactions should be set to False on the end-user side so I don't think this would affect end users under normal circumstances. We actually added the store_all_transactions option to perform network analytics and to get insights in the dynamics of bandwidth transfers (since we would like to analyse as much transactions as possible). However, a user is able enable this flag by enabling the crawler mode of the bandwidth component. Maybe this is what happened and triggered the bug.