Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the folders structure #6803

Merged
merged 14 commits into from
Mar 14, 2022
Merged

Refactoring the folders structure #6803

merged 14 commits into from
Mar 14, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Mar 9, 2022 •
edited
Loading

This PR implements folders' restructuration that was described in #6505

To check the new folder structure, go to https://github.com/Tribler/tribler/tree/refactoring/folders_restructure

@drew2a drew2a force-pushed the refactoring/folders_restructure branch from 3b4fb6d to 3505a53 Compare March 9, 2022 11:23
@drew2a drew2a force-pushed the refactoring/folders_restructure branch 2 times, most recently from 8e27c71 to 3781ea6 Compare March 9, 2022 12:10
@drew2a drew2a force-pushed the refactoring/folders_restructure branch from 3781ea6 to 50c9571 Compare March 9, 2022 12:37
@drew2a drew2a force-pushed the refactoring/folders_restructure branch 4 times, most recently from c4fd61e to 0e0b742 Compare March 11, 2022 15:34
@drew2a drew2a requested a review from kozlovsky March 11, 2022 16:39
@drew2a drew2a marked this pull request as ready for review March 11, 2022 16:39
@drew2a drew2a requested a review from a team March 11, 2022 16:40
kozlovsky
kozlovsky suggested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@kozlovsky kozlovsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

There are places where pyipv8 references should be removed as well (remnants from #6757). I cannot specify them in the review, as these files were moved without change and the diff is unavailable, but you can find them with "pyipv8" search. I mean src/tribler/core/__init__.py and six examples in the srcipts folder. In these lines, tribler-core is also mentioned and should be removed, so logically this fix belongs to the current PR.

tribler.spec Outdated Show resolved Hide resolved
scripts/bandwidth_crawler/README.md Outdated Show resolved Hide resolved
src/tribler/core/logger/logger.yaml Outdated Show resolved Hide resolved
src/run_tribler.bat Outdated Show resolved Hide resolved
scripts/exit_node/README.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 192 Security Hotspots
Code Smell A 299 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@drew2a
PR fixes requested by @kozlovsky
f9ae17f 
Update root level files


Update docs


Fix tests


Update tribler.spec

Co-authored-by: Alexander Kozlovsky <[email protected]>
Update scripts/bandwidth_crawler/README.md

Co-authored-by: Alexander Kozlovsky <[email protected]>
Update src/tribler/core/logger/logger.yaml

Co-authored-by: Alexander Kozlovsky <[email protected]>
Update src/README.md

Co-authored-by: Alexander Kozlovsky <[email protected]>
Update scripts/exit_node/README.md

Co-authored-by: Alexander Kozlovsky <[email protected]>
Update src/run_tribler.bat

Co-authored-by: Alexander Kozlovsky <[email protected]>
Update PYTHONPATH imports
@drew2a drew2a force-pushed the refactoring/folders_restructure branch from 64370d0 to f9ae17f Compare March 14, 2022 11:15
@drew2a drew2a requested a review from kozlovsky March 14, 2022 11:43
kozlovsky
kozlovsky suggested changes Mar 14, 2022
View reviewed changes
src/tribler/gui/upgrade_manager.py Outdated Show resolved Hide resolved
@drew2a drew2a requested a review from kozlovsky March 14, 2022 12:12
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 192 Security Hotspots
Code Smell A 299 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@drew2a drew2a merged commit 40e33bb into main Mar 14, 2022
@drew2a drew2a deleted the refactoring/folders_restructure branch March 15, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drew2a @kozlovsky