-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "no_parallel" pytest's mark #6799
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The current Jenkins test run is the following: pytest src/tribler-core -v --tx '12*popen//execmodel=eventlet' -p no:randomly --cov=tribler_core --cov-report=xml:../output/coverage.xml --junitxml=test_report.xml
# Tunnel tests
pytest src/tribler-core/tribler_core/components/tunnel/tests/test_full_session --tunneltests --log-cli-level=INFO
pytest src/tribler-core -v -p no:randomly --no_parallel @devos50 @kozlovsky do you know, is it possible to share coverage reports among the different test runs? It would be nice to include coverage from |
@drew2a yes, I believe cobertura has an option to merge separate code coverage files into one (but they need to have the same base path). We should merge the reports generated by the "no parallel" and parallel test runs. For the tunnel tests, however, I'm not so sure: the tunnel tests are more leaning to a full-fletched application test and the code coverage reported by them might hide lines that are uncovered by our unit tests. |
@devos50 ok, thanks. I'll find a way to merge coverage for |
@drew2a it should be possible to use the Then the Jenkins command will look like:
|
Jenkins jobs that run for a PR have been updated (Win, Linux, MacOS). |
This PR fixes #6709 by introducing the
no_parallel
pytest's mark.All tests that have this mark will be excluded from normal "parallel" Jenkins's run. But they will be run sequentially instead (like tunnel tests do).
In case this PR will be approved, I will merge it to the main and then modify corresponding Jenkins' jobs.