Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing notifier topic observers based on enum values #6753

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Feb 2, 2022

Fixes #6751

@xoriole
Copy link
Contributor Author

xoriole commented Feb 3, 2022

retest this please

1 similar comment
@xoriole
Copy link
Contributor Author

xoriole commented Feb 3, 2022

retest this please

@xoriole
Copy link
Contributor Author

xoriole commented Feb 3, 2022

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
/usr/local/Cellar/[email protected]/3.8.4/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1014: in _gcd_import
    ???
<frozen importlib._bootstrap>:991: in _find_and_load
    ???
<frozen importlib._bootstrap>:975: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:671: in _load_unlocked
    ???
/Users/tribler/Library/Python/3.8/lib/python/site-packages/_pytest/assertion/rewrite.py:170: in exec_module
    exec(co, module.__dict__)
src/tribler-core/tribler_core/conftest.py:14: in <module>
    from tribler_common.network_utils import default_network_utils
E   ModuleNotFoundError: No module named 'tribler_common'

Seems different PR sources are getting mixed on Jenkins

@xoriole
Copy link
Contributor Author

xoriole commented Feb 3, 2022

retest this please

1 similar comment
@xoriole
Copy link
Contributor Author

xoriole commented Feb 3, 2022

retest this please

@drew2a
Copy link
Contributor

drew2a commented Feb 4, 2022

@xoriole

Seems different PR sources are getting mixed on Jenkins

I guess it is coming from #6755.
But I don't understand how it is possible.

@kozlovsky
Copy link
Contributor

It seems that when Jenkins job clones the Tribler repo, it sometimes clones a previous state of Tribler repo that was intended for the previous instance of this job.

@xoriole
Copy link
Contributor Author

xoriole commented Feb 4, 2022

retest this please

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xoriole xoriole marked this pull request as ready for review February 4, 2022 14:09
@xoriole xoriole requested review from a team and drew2a and removed request for a team February 4, 2022 14:09
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xoriole xoriole merged commit f36bf3d into Tribler:main Feb 4, 2022
@xoriole xoriole deleted the fix/event-stream branch August 31, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[main] Tribler does not refresh discovery page
3 participants