Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allow_exit_node_checkbox #6736

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Remove allow_exit_node_checkbox #6736

merged 1 commit into from
Jan 21, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jan 20, 2022

Based on yesterday's discussion, this PR removes allow_exit_node_checkbox from UI as potentially dangerous for a user.

image

@drew2a drew2a added this to the 7.12.0 January milestone Jan 20, 2022
@drew2a drew2a self-assigned this Jan 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a drew2a requested a review from xoriole January 20, 2022 10:37
@drew2a drew2a marked this pull request as ready for review January 20, 2022 10:37
@drew2a drew2a requested a review from a team January 20, 2022 10:37
@devos50
Copy link
Contributor

devos50 commented Jan 20, 2022 •
edited
Loading

If we are to remove this option from the GUI, should we provide some documentation instead on how to enable the exit node functionality if a user really wants this?

xoriole
xoriole approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@xoriole xoriole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this

@drew2a drew2a merged commit 4905494 into Tribler:main Jan 21, 2022
@drew2a
Copy link
Contributor Author

drew2a commented Jan 21, 2022

@devos50 everything should be documented :)

@kozlovsky kozlovsky mentioned this pull request Jun 4, 2022
Closed
@drew2a drew2a mentioned this pull request Jul 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoriole xoriole xoriole approved these changes

Assignees

@drew2a drew2a

Labels
None yet
Milestone
7.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@drew2a @devos50 @xoriole