Fix run_bandwidth_crawler script #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/run_bandwidth_crawler
branch
3 times, most recently
from
211d08c to
97fe0aa
Compare
|
retest this please |
kozlovsky
force-pushed
the
fix/run_bandwidth_crawler
branch
3 times, most recently
from
64b8fbf to
da126dd
Compare
kozlovsky
requested review from
a team,
xoriole and
drew2a
and removed request for
a team
drew2a
previously approved these changes
Jan 18, 2022
kozlovsky
force-pushed
the
fix/run_bandwidth_crawler
branch
from
da126dd to
aced845
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix the script to run bandwidth crawler. It initializes BandwidthDatabase and BandwidthAccountingCommunity in a bit different way comparing to Tribler itself, so I added
crawler_modeflag toBandwidthAccountingComponent. Another options was to add an option to BandwidthAccounting section of TriblerConfig, but the option does not look important enough to complicate the general config.