Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapped 'cancel' and 'download' buttons #6727

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Swapped 'cancel' and 'download' buttons #6727

merged 1 commit into from
Jan 17, 2022

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Jan 17, 2022

Fixes #6712. The order of the buttons in the start download dialog is now consistent with the button order in other dialogs.

Before:
Schermafbeelding 2022-01-17 om 09 23 28

After:
Schermafbeelding 2022-01-17 om 09 25 51

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devos50 devos50 marked this pull request as ready for review January 17, 2022 08:36
@devos50 devos50 requested review from a team and kozlovsky and removed request for a team January 17, 2022 08:36
@devos50 devos50 merged commit eed41c7 into Tribler:main Jan 17, 2022
@devos50 devos50 deleted the start_download_dialog_changes branch January 17, 2022 15:39
@drew2a drew2a removed the request for review from kozlovsky January 17, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent interface while adding magnet link.
2 participants
@devos50 @drew2a