Move discovery_booster to ipv8 component
#6719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
refactoring/booster
branch
from
8d86727 to
dbff5ce
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
xoriole
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
discovery_boosterto theipv8component.The reason:
discovery_boosteris designed as a community-independent tool and can be used along with any community. It has been placed to theGigachannelcomponent because it has been used only by this component.Now not only the
Gigachannelcomponent is a user of this booster. So, the booster should be located in a more general location (like theipv8component).