Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade mistune from 0.8.4 to 2.0.1 #6695

Closed
wants to merge 1 commit into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • doc/requirements.txt

Vulnerabilities that will be fixed

By pinning:
Severity Priority Score (*) Issue Upgrade Breaking Change Exploit Maturity
medium severity 556/1000
Why? Recently disclosed, Has a fix available, CVSS 5.4
Cross-site Scripting (XSS)
SNYK-PYTHON-MISTUNE-2328096
mistune:
0.8.4 -> 2.0.1
No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the effected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-MISTUNE-2328096
@snyk-bot snyk-bot requested review from a team and drew2a and removed request for a team December 31, 2021 07:39
@tribler-ci
Copy link
Contributor

Can one of the admins verify this patch?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@qstokkink
Copy link
Contributor

ok to test

@drew2a
Copy link
Contributor

drew2a commented Dec 31, 2021

Build documentation failed:

Traceback (most recent call last):
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinx/application.py", line 237, in __init__
    self.setup_extension(extension)
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinx/application.py", line 394, in setup_extension
    self.registry.load_extension(self, extname)
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinx/registry.py", line 429, in load_extension
    mod = import_module(extname)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinxcontrib/openapi/__init__.py", line 13, in <module>
    from sphinxcontrib.openapi import renderers, directive
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinxcontrib/openapi/renderers/__init__.py", line 4, in <module>
    from ._httpdomain_old import HttpdomainOldRenderer
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinxcontrib/openapi/renderers/_httpdomain_old.py", line 6, in <module>
    from .. import openapi20, openapi30, utils
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinxcontrib/openapi/openapi20.py", line 16, in <module>
    from sphinxcontrib.openapi import utils
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/sphinxcontrib/openapi/utils.py", line 20, in <module>
    from m2r import convert as convert_markdown
  File "/home/jenkins/workspace/GH_Tribler_PR_Tests/PR_build_docs/venv/lib/python3.8/site-packages/m2r.py", line 59, in <module>
    class RestBlockGrammar(mistune.BlockGrammar):
AttributeError: module 'mistune' has no attribute 'BlockGrammar'

@devos50
Copy link
Contributor

devos50 commented Jan 3, 2022

Related issue: #6624

Seems that sphinx-contrib/openapi has not been updated for over a year. Unless we remove this dependency, we have to pin an older version of mistune.

@drew2a
Copy link
Contributor

drew2a commented Jan 3, 2022

@devos50 thank you for clarifying this.

The snyk issue will be ignored for the upcoming 3 months.

@drew2a drew2a closed this Jan 3, 2022
@drew2a drew2a deleted the snyk-fix-4ab0f8d54239c5684ec7fdc1655e3fe2 branch May 2, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants