Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6653 #6694

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Fix 6653 #6694

merged 5 commits into from
Jan 4, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Dec 29, 2021

This PR fixes #6653 by switching SentryReporter to a normal class instead of a singleton.

Tests of SentryReporter have been rewritten.

As a part of SentryReporter's tests refactoring, the ability to pass a module-as-a-string has been added to patch_import.

Fix test_gui_error_suppressed
@drew2a drew2a requested a review from kozlovsky December 30, 2021 14:45
@drew2a drew2a marked this pull request as ready for review December 30, 2021 14:45
@drew2a drew2a requested a review from a team December 30, 2021 14:45
@drew2a drew2a marked this pull request as draft January 3, 2022 15:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a drew2a marked this pull request as ready for review January 3, 2022 17:11
@drew2a drew2a requested a review from ichorid January 3, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[main] test_unhandled_error_observer_only_message test flapping
3 participants