Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct range for Y-axis of the token balance graph #6668

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

kozlovsky
Copy link
Contributor

This PR fixes #6667. Now TrustPage.plot_absolute_values dynamically sets the range for Y-axis depending on the received data.

After the fix, the graph displays data correctly, and Y-axis is adequately scaled.

2021-12-20_10-24-41

@kozlovsky kozlovsky requested review from a team and drew2a and removed request for a team December 20, 2021 09:46
@kozlovsky kozlovsky force-pushed the fix/token_balance_range branch from f5f1efb to 9ee1369 Compare December 20, 2021 09:51
@kozlovsky kozlovsky marked this pull request as draft December 20, 2021 09:59
@kozlovsky kozlovsky removed the request for review from drew2a December 20, 2021 10:00
@kozlovsky
Copy link
Contributor Author

retest this please

@kozlovsky kozlovsky force-pushed the fix/token_balance_range branch from 75b78ff to 00b1c1a Compare December 20, 2021 13:29
@kozlovsky kozlovsky force-pushed the fix/token_balance_range branch from 00b1c1a to 2bf88e6 Compare December 20, 2021 13:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kozlovsky kozlovsky marked this pull request as ready for review December 20, 2021 13:40
@kozlovsky kozlovsky requested a review from xoriole December 20, 2021 13:40
Copy link
Contributor

@xoriole xoriole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kozlovsky kozlovsky merged commit 3458801 into Tribler:main Dec 20, 2021
@kozlovsky kozlovsky deleted the fix/token_balance_range branch December 20, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect token balance graph is displayed
2 participants