Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker and sentry as common dependency #6656

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Add Faker and sentry as common dependency #6656

merged 2 commits into from
Dec 20, 2021

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Dec 15, 2021

Fixes #6655

Additional to faker, sentry-sdk is required.

Tested buid here: https://jenkins-ci.tribler.org/job/pers/job/TRIBLER-PR-JOBS/job/PR_build_docs/9/

@xoriole xoriole marked this pull request as ready for review December 15, 2021 09:57
@xoriole xoriole requested review from a team and drew2a and removed request for a team December 15, 2021 09:57
@drew2a
Copy link
Contributor

drew2a commented Dec 15, 2021

Nice! To keep the integrity of test_dependencies.py we need to revert this line:
9427d27#diff-c4e1e86fbbab8a03655c675cee5ea28fc87db3b7132cec38fe074480b2a10274L40

Or in another word, we should add the following line to the L40 of test_dependencies.py

assert list(get_dependencies(Scope.common))

drew2a
drew2a suggested changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested line is still not added :)

@xoriole xoriole marked this pull request as draft December 17, 2021 11:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@xoriole xoriole requested a review from kozlovsky December 20, 2021 10:08
@xoriole xoriole marked this pull request as ready for review December 20, 2021 10:08
@xoriole xoriole requested a review from drew2a December 20, 2021 10:19
@xoriole
Copy link
Contributor Author

xoriole commented Dec 20, 2021

@drew2a Requested changes are applied

Nice! To keep the integrity of test_dependencies.py we need to revert this line: 9427d27#diff-c4e1e86fbbab8a03655c675cee5ea28fc87db3b7132cec38fe074480b2a10274L40

Or in another word, we should add the following line to the L40 of test_dependencies.py

assert list(get_dependencies(Scope.common))

@xoriole xoriole merged commit 0b663ed into Tribler:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

@drew2a drew2a Awaiting requested review from drew2a

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation build failing - missing module faker
3 participants
@xoriole @drew2a @kozlovsky