-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] User identicons #6654
[WIP] User identicons #6654
Conversation
445b3a7
to
839069f
Compare
839069f
to
43ce803
Compare
7c93c46
to
5ed5571
Compare
5ed5571
to
ab6cfdf
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I had a closer look at this proposed feature and played a bit around in GUI test mode to get a better feeling for it. First, I was wondering about the problem it would solve. Since #5154 has been linked, it would allow for quicker identification of the channel each torrent originates from. I am mostly familiar with identifications from GitHub and they can help to quicker identify users. In the context of Tribler, however, I’m not sure if they serve their purpose, for the following reasons:
Then, when going to the list of torrents, I see all these identicons. I would think that each identicon would uniquely identify the torrent but that does not seem to be the case: Multiple torrents are sharing the same identicon, which makes sense if you know that the identicon links to the channel, but that’s not clear for me at a first glance. There is a tooltip with the channel name, but for that to be effective, I think the identicon should also be clickable. Overall, I’m not convinced that they effectively solve the problem in their current form.
Some alternatives I can think of:
Note that my findings above are obviously subjective and other people might have a completely different experience when interacting with particular GUI elements. In general, I think it’s the best to not deviate too much from the user interfaces of established applications, and take inspiration from them. Are there any major applications that are embedding identicons in a scrollable list? |
Identicons show channels authors. The purpose of this PR is to allow users to visually identify trusted channel authors. Regarding the source channel problem, there is another PR that solves that with clickable tooltips. |
We have discussed this functionality in the weekly developer meetings. While we appreciate the efforts and like identicons, the general consensus is that we do not have time to further pursue this approach at the moment. Instead, we would like to look into these kind of GUI improvements the moment when we are going to make changes to the way we organise and present content. |
fixes #5154