Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] User identicons #6654

Closed
wants to merge 2 commits into from
Closed

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Dec 14, 2021

fixes #5154

изображение

@ichorid ichorid added this to the 7.12.0 December milestone Dec 14, 2021
@ichorid ichorid force-pushed the feature/users_identicons branch 2 times, most recently from 445b3a7 to 839069f Compare December 24, 2021 22:00
@ichorid ichorid force-pushed the feature/users_identicons branch from 839069f to 43ce803 Compare January 7, 2022 22:45
@ichorid ichorid changed the title [WIP] User identicons and links to parent channels [WIP] User identicons Jan 7, 2022
@ichorid ichorid force-pushed the feature/users_identicons branch 4 times, most recently from 7c93c46 to 5ed5571 Compare January 7, 2022 23:26
@ichorid ichorid force-pushed the feature/users_identicons branch from 5ed5571 to ab6cfdf Compare January 7, 2022 23:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devos50
Copy link
Contributor

devos50 commented Jan 18, 2022

I had a closer look at this proposed feature and played a bit around in GUI test mode to get a better feeling for it.

First, I was wondering about the problem it would solve. Since #5154 has been linked, it would allow for quicker identification of the channel each torrent originates from.

I am mostly familiar with identifications from GitHub and they can help to quicker identify users. In the context of Tribler, however, I’m not sure if they serve their purpose, for the following reasons:

  • When presented in a linear list, I feel overwhelmed by all these identicons and I mostly ignore them:

Schermafbeelding 2022-01-18 om 10 28 39

Then, when going to the list of torrents, I see all these identicons. I would think that each identicon would uniquely identify the torrent but that does not seem to be the case:

Schermafbeelding 2022-01-18 om 10 03 40

Multiple torrents are sharing the same identicon, which makes sense if you know that the identicon links to the channel, but that’s not clear for me at a first glance. There is a tooltip with the channel name, but for that to be effective, I think the identicon should also be clickable. Overall, I’m not convinced that they effectively solve the problem in their current form.

  • We should be very careful with introducing new elements/columns in the tables that showcase content. Our tables already contain quite a few elements that might not be clear to the user. One can make the same argument for the recently added tags. However, that is a GUI element that has been heavily discussed and we tried to made them as non-intrusive as possible. Though I have to say that these identicons look ok in the ‘discovered channels’ page (they break the bland style), I think there are preferable alternatives.

Some alternatives I can think of:

  • We used to have an additional part of the screen to show detailled torrent information (e.g., its trackers). This would have been the perfect place for that kind of information, but that part got removed (I don’t really remember why we did remove that though, there was probably a good reason for it).
  • Maybe a cleaner solution is to show the channel name just under the title of a torrent, just like YouTube is doing. This text would then also be clickable and it would bring you to the channel the torrent is part of.

Note that my findings above are obviously subjective and other people might have a completely different experience when interacting with particular GUI elements. In general, I think it’s the best to not deviate too much from the user interfaces of established applications, and take inspiration from them. Are there any major applications that are embedding identicons in a scrollable list?

@ichorid
Copy link
Contributor Author

ichorid commented Jan 18, 2022

Identicons show channels authors. The purpose of this PR is to allow users to visually identify trusted channel authors.

Regarding the source channel problem, there is another PR that solves that with clickable tooltips.

@devos50
Copy link
Contributor

devos50 commented Jan 24, 2022

We have discussed this functionality in the weekly developer meetings. While we appreciate the efforts and like identicons, the general consensus is that we do not have time to further pursue this approach at the moment. Instead, we would like to look into these kind of GUI improvements the moment when we are going to make changes to the way we organise and present content.

@devos50 devos50 closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Identicons for users and channels' authors
2 participants