Remove spam in pytest output #6620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team,
xoriole and
devos50
and removed request for
a team
|
retest this please |
devos50
reviewed
Dec 3, 2021
src/tribler-core/tribler_core/components/restapi/restapi_component.py
Outdated
Show resolved
Hide resolved
kozlovsky
force-pushed
the
fix/warnings_in_tests
branch
4 times, most recently
from
eaee228 to
b1a0355
Compare
…timeout() instead"
…' because it has a __init__ constructor"
…Python 3.9 and will be removed in a subsequent version"
…ted setResizeMode method
kozlovsky
force-pushed
the
fix/warnings_in_tests
branch
from
b1a0355 to
0ff670e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
retest this please |
1 similar comment
|
retest this please |
ichorid
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pytest output has many unimportant warnings from third-party libraries. We can safely ignore all of them. Displaying all these warnings makes understanding pytest results more complex than necessary. It is essential that if we get some new and important warning one day, we can easily miss it in this wall of existing warnings.
In this PR, I update the
pytest.iniconfig file to suppress all unimportant warnings and also I suppress warnings in code when necessary.Also, I switched the default logging level in tests from DEBUG to INFO. In most cases, DEBUG output is not helpful, as it mainly consists of spam generated by internal PyQt modules. So, most of the time, it makes test results harder to understand. If necessary, we can always switch it back to DEBUG level later when analyzing some specific test failure.