Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace random char generation by fake words #6592

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Nov 29, 2021

This PR affects only Tribler's work in GUI test mode.

This PR replaces random char generation by fake words:

image
image
image
image

@drew2a drew2a force-pushed the feature/generate_fake_content branch from f99c228 to b684202 Compare November 29, 2021 12:08
@drew2a drew2a changed the title Replace random words by fake words Replace random char generation by fake words Nov 29, 2021
@drew2a drew2a force-pushed the feature/generate_fake_content branch from b684202 to 55dc478 Compare November 29, 2021 12:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a drew2a marked this pull request as ready for review November 29, 2021 12:38
@drew2a drew2a requested review from a team, kozlovsky and devos50 and removed request for a team November 29, 2021 12:38
Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it looks better, we have actually discovered bugs related to Unicode characters in the past. Not using non-ASCII characters in the GUI test mode might hide these bugs.

@drew2a
Copy link
Contributor Author

drew2a commented Nov 29, 2021

Even though it looks better, we have actually discovered bugs related to Unicode characters in the past. Not using non-ASCII characters in the GUI test mode might hide these bugs.

Agree but discovering such bugs is closer to the set of responsibilities of Application Tester rather then GUI test mode.

@drew2a drew2a merged commit 563ab49 into Tribler:main Nov 29, 2021
@drew2a drew2a mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants