Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify GUI-Core startup sequence #6573

Merged
merged 8 commits into from
Nov 24, 2021
Merged

Simplify GUI-Core startup sequence #6573

merged 8 commits into from
Nov 24, 2021

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Nov 23, 2021

fixes #6526

The third and the last part of #6535

  1. Remove StateEndpoint and all Tribler startup state-related code.
  2. Refactor all the endpoints to use true dependency injection. No late assignment of attributes anymore!
  3. Move the initialization of all the endpoints into the RESTComponent. The relationship between RESTComponent and other components are now reversed: RESTComponent now depends on every other component that has something to do with the endpoints.
  4. All the endpoints are now initialized in one go, in the RESTComponent
  5. CoreManager in the GUI is now split into two parts: CoreManager and UpgradeManager. UpgraderManager runs upgrader routines in a QThread. When it finishes, CoreManager is run as usual.

@ichorid ichorid force-pushed the refactor/rest_component branch 5 times, most recently from 071fa7c to 265e717 Compare November 23, 2021 18:45
@ichorid ichorid marked this pull request as ready for review November 23, 2021 18:57
@ichorid ichorid requested review from a team and xoriole and removed request for a team November 23, 2021 18:57
@ichorid ichorid force-pushed the refactor/rest_component branch from 265e717 to c5bb53d Compare November 23, 2021 18:58
@ichorid ichorid force-pushed the refactor/rest_component branch from c5bb53d to 287446a Compare November 23, 2021 20:46
This was referenced Nov 24, 2021
Closed
Closed
drew2a
drew2a suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement in general! I've left some comments.

doc/extract_swagger.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/patch_import.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/patch_import.py Outdated Show resolved Hide resolved
src/tribler-core/tribler_core/components/restapi/restapi_component.py Show resolved Hide resolved
src/tribler-core/tribler_core/components/restapi/restapi_component.py Outdated Show resolved Hide resolved
devos50
devos50 reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! I have a few minor comments here and there.

src/tribler-core/tribler_core/components/metadata_store/restapi/metadata_endpoint_base.py Outdated Show resolved Hide resolved
src/tribler-core/tribler_core/components/restapi/rest/debug_endpoint.py Outdated Show resolved Hide resolved
src/tribler-core/tribler_core/components/restapi/rest/events_endpoint.py Outdated Show resolved Hide resolved
src/tribler-core/tribler_core/components/tag/restapi/tags_endpoint.py Outdated Show resolved Hide resolved
@ichorid ichorid force-pushed the refactor/rest_component branch from b00a269 to b95ffaa Compare November 24, 2021 14:24
@ichorid ichorid requested review from drew2a and devos50 November 24, 2021 14:31
devos50
devos50 previously approved these changes Nov 24, 2021
View reviewed changes
drew2a
drew2a suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes were not addressed.

@ichorid ichorid force-pushed the refactor/rest_component branch 4 times, most recently from e415533 to 41221ad Compare November 24, 2021 17:36
drew2a
drew2a suggested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor and easy-to-fix comments.

src/tribler-common/tribler_common/tests/test_dependencies.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/tests/test_patch_import.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/tests/test_patch_import.py Outdated Show resolved Hide resolved
@ichorid ichorid force-pushed the refactor/rest_component branch from 41221ad to dd641c2 Compare November 24, 2021 17:55
@ichorid ichorid force-pushed the refactor/rest_component branch from dd641c2 to 9427d27 Compare November 24, 2021 18:02
@drew2a drew2a self-requested a review November 24, 2021 18:02
drew2a
drew2a approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the questions and for this improvement.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@ichorid ichorid merged commit 46c2436 into Tribler:main Nov 24, 2021
@ichorid ichorid deleted the refactor/rest_component branch November 24, 2021 18:13
@drew2a drew2a mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

@devos50 devos50 devos50 left review comments

@xoriole xoriole Awaiting requested review from xoriole

@kozlovsky kozlovsky Awaiting requested review from kozlovsky

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI-Core startup communication is too complicated
3 participants
@ichorid @devos50 @drew2a