Make CoreExceptionHandler scope-dependent #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
fix/6542
branch
2 times, most recently
from
f3ddd97 to
324b4f5
Compare
drew2a
changed the title
drew2a
force-pushed
the
fix/6542
branch
2 times, most recently
from
bf85c7b to
942dc17
Compare
kozlovsky
previously approved these changes
Nov 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6542 by making CoreExceptionHandler just an instance class (instead of singleton). It will allow us to test
CoreExceptionHandlerproperly and will increase the stability of tests.