Change mock type for encode_message #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
previously approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Confirmed fix. My setup of #6539 (comment) no longer leads to an unawaited coroutine.
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
This was referenced Nov 10, 2021
kozlovsky
previously approved these changes
Nov 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6539 by removing
AsyncMockfromencode_messagepatch becauseencode_messageuses only in synchronized calls.As a consequence of doing this: removed warning and fixed
test_set_rate_settingstest.See full explanations here: #6539