Moved tag rect metadata to a separate dictionary in model #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devos50
force-pushed
the
tag_rect_model
branch
from
fefa8e8 to
6aa26c6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Triggered #6502 |
|
retest this please |
devos50
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hindsight, adding the
QRectFdata to thedata_itemsis not the best strategy. These changes move the tag rectangle metadata outsidedata_itemsinto a separate dictionary. This dictionary is also cleared when the model resets.Fixes #6498