Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge mds module and component #6378

Merged
merged 11 commits into from
Sep 28, 2021
Merged

Merge mds module and component #6378

merged 11 commits into from
Sep 28, 2021

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Sep 28, 2021 •
edited
Loading

This PR contains location changes of files from the metadata_store module.

The new structure: https://github.com/drew2a/tribler/tree/feature/merge_mds/src/tribler-core/tribler_core/components/metadata_store

image

Addresses #6335

@drew2a drew2a marked this pull request as ready for review September 28, 2021 09:57
@drew2a drew2a requested review from a team, xoriole and ichorid and removed request for a team and xoriole September 28, 2021 09:57
@drew2a drew2a changed the title Merge mds Merge mds module and component Sep 28, 2021
ichorid
ichorid suggested changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@ichorid ichorid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gigachannel community-related files must be placed along with the gigachannel community component, not with MDS.

Also, DB-related tests, such as test_metadata, must be placed close to DB code, e.g. in metadata_store/db/tests

@drew2a
Copy link
Contributor Author

drew2a commented Sep 28, 2021

@ichorid

The gigachannel community-related files must be placed along with the gigachannel community component, not with MDS.
Also, DB-related tests, such as test_metadata, must be placed close to DB code, e.g. in metadata_store/db/tests

Fixed. Internals of MDS are quite intertwined, so I tried my best to split them into components.
But it is not the intention of the PR. The intention of the PR is to merge MDS module and MDS component.

If you find other misplaced internals, please move them on your own.

@drew2a drew2a marked this pull request as draft September 28, 2021 11:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@drew2a drew2a marked this pull request as ready for review September 28, 2021 11:28
@drew2a drew2a merged commit 8c51ae6 into Tribler:main Sep 28, 2021
@drew2a drew2a deleted the feature/merge_mds branch September 28, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichorid ichorid ichorid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drew2a @ichorid