Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix community component shutdown leaving stuff behind #6338

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fix community component shutdown leaving stuff behind #6338

merged 1 commit into from
Sep 22, 2021

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Sep 21, 2021

fixes #6248

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@ichorid ichorid requested a review from qstokkink September 21, 2021 16:39
@ichorid ichorid marked this pull request as ready for review September 21, 2021 16:39
qstokkink
qstokkink approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, fixes the core issue 👍

Note: the switch from strategies.append + overlays.append to add_strategy, documented #6248, should be moved to a new "enhancement" issue after this PR is merged.

@ichorid ichorid merged commit 46dfe31 into Tribler:main Sep 22, 2021
@ichorid ichorid deleted the fix_6248 branch September 22, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qstokkink qstokkink qstokkink approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] Community component shutdown leaves stuff behind
2 participants
@ichorid @qstokkink