Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DateAxisItem custom implementation #6198

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Jul 2, 2021

DateAxisItem is now merged in pyqtgraph so we don't need the custom implementation anymore.

@xoriole
Copy link
Contributor Author

xoriole commented Jul 2, 2021

Test on Windows 64-bit failed, not related to this PR

Error Message

AttributeError: 'NoneType' object has no attribute 'split'

Stacktrace

self = <test_triblertunnel_community.TestTriblerTunnelCommunity testMethod=test_perform_http_request_multipart>

    async def test_perform_http_request_multipart(self):
        """
        Test whether getting a large HTTP response works
        """
        self.add_node_to_experiment(self.create_node())
        self.nodes[1].overlay.settings.peer_flags.add(PEER_FLAG_EXIT_HTTP)
        await self.introduce_nodes()
    
        http_port = TestTriblerTunnelCommunity.get_free_port()
        http_tracker = HTTPTracker(http_port)
        http_tracker.tracker_info.add_info_about_infohash('0', 0, 0)
        http_tracker.tracker_info.infohashes['0']['downloaded'] = os.urandom(10000)
        await http_tracker.start()
        response = await self.nodes[0].overlay.perform_http_request(('127.0.0.1', http_tracker.port),
                                                                    b'GET /scrape?info_hash=0 HTTP/1.1\r\n\r\n')
    
>       self.assertEqual(response.split(b'\r\n')[0], b'HTTP/1.1 200 OK')
E       AttributeError: 'NoneType' object has no attribute 'split'

src\tribler-core\tribler_core\modules\tunnel\tests\test_triblertunnel_community.py:593: AttributeError

@xoriole
Copy link
Contributor Author

xoriole commented Jul 2, 2021

retest this please

@devos50
Copy link
Contributor

devos50 commented Jul 2, 2021

@xoriole I couldn't find an existing issue for this stack trace. Let's create one?

@xoriole xoriole marked this pull request as ready for review July 2, 2021 09:24
@xoriole xoriole requested a review from devos50 July 2, 2021 09:24
@xoriole xoriole force-pushed the fix/timeseriesgraph branch from 9e117b0 to 367342f Compare July 2, 2021 10:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@xoriole xoriole merged commit 1a49341 into Tribler:main Jul 2, 2021
@xoriole xoriole deleted the fix/timeseriesgraph branch July 2, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants