WIP Add dependency-injector to Tribler #6197
Conversation
| working_dir, config_path) | ||
|
|
||
| self._interval_in_sec = interval_in_sec | ||
| self._output_file_path = output_file_path | ||
|
|
||
| self.application = containers.ApplicationContainer(state_dir=config.state_dir) | ||
| self.application.config.from_pydantic(config) | ||
| self.application.wire(modules=[Session]) |
There was a problem hiding this comment.
A good start point to discover PR.
| endpoint = providers.Singleton( | ||
| DispatcherEndpoint, | ||
| providers.List(providers.Object("UDPIPv4")), | ||
| UDPIPv4=providers.Dict(port=providers.Factory(config.port), ip=providers.Factory(config.address)), |
There was a problem hiding this comment.
Yep, this line looks not too intuitive 😕. I would expect it to be just UDPIPv4={'port':config.port}, etc. Why the Factory stuff is necessary here, what's the semantic reason? Lazy initialization?
There was a problem hiding this comment.
It can be replaced by:
endpoint = providers.Singleton(
DispatcherEndpoint, ["UDPIPv4"],
UDPIPv4=providers.Dict(port=config.port, ip=config.address),
)Explanations later...
There was a problem hiding this comment.
If you use UDPIPv4={'port':config.port} you'll get:
{'UDPIPv4': {'port': <dependency_injector.providers.ConfigurationOption('config.port') at 0x112961eb0>}}
| from tribler_core.utilities.path_util import Path | ||
|
|
||
|
|
||
| class TrustChainKeys: |
There was a problem hiding this comment.
In the future, it is better to leave only the single keypair property in the code, loading either the real key or the testnet key based on the config option. AFAIK, there are no situations where both keys are used in the code simultaneously.
|
Looks promising! I see you're going to introduce DependencyInjector, but you're still keeping the Session in, right? |
|
Looks good 👍 All my implementation feedback is already covered by @ichorid. I have two meta questions about what you wrote in O.P.:
|
|
Kudos, SonarCloud Quality Gate passed!
|
This is an example of DI in Tribler.
I've tested it on
initial_filling.pyandrun_tribler.py.What can I say after a day of work: it works but the framework is surprisingly difficult to understand.
I spent all day trying to make this example runnable.
Partially it is because of the
session.pyorganization, but mainly because of the unintuitive framework.(I am not stating that it is bad, but only that it is unintuitive).
Please disregard the writing style, I didn't work on it.
I want to show you roughly what the Tribler with DI will look like.
Framework: https://python-dependency-injector.ets-labs.org/
@ichorid example: https://github.com/Tribler/tribler/pull/6185/files
References:
#4953
#6177