Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pydantic #6168

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Add pydantic #6168

merged 2 commits into from
Jun 22, 2021

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jun 18, 2021

Tribler config is a pydantic's BaseModel now.

It still writes and loads data from ini-file (named somewhy triblerd.conf in Tribler)

More information: https://pydantic-docs.helpmanual.io/usage/models/

@drew2a drew2a force-pushed the refactoring/pydantic branch 2 times, most recently from 5c2580b to 8485775 Compare June 21, 2021 12:18
@drew2a drew2a force-pushed the refactoring/pydantic branch 3 times, most recently from c4f1b83 to 5c2bf9e Compare June 21, 2021 19:49
@drew2a drew2a force-pushed the refactoring/pydantic branch from 5c2bf9e to 6c25dac Compare June 21, 2021 19:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a drew2a marked this pull request as ready for review June 21, 2021 20:48
@ichorid
Copy link
Contributor

ichorid commented Jun 21, 2021

🎉 👏

@drew2a drew2a changed the title WIP Add pydantic Add pydantic Jun 22, 2021
@drew2a drew2a merged commit 69a88a4 into Tribler:main Jun 22, 2021
@drew2a drew2a deleted the refactoring/pydantic branch June 22, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants