Adopt AppStream

[overflw]

With those small changes I hope to make tribler compatible with the AppStream standard. I couldn't test the changes yet, because tribler won't build for me at the moment.

[tribler-ci]

Can one of the admins verify this patch?

[devos50]

ok to test

[devos50]

We refrain from hard-coding versions in our files. Please have a look at this script that is executed before packaging Tribler 👍

[qstokkink]

@overflw this is a way to satisfy this request for changes:

1. Remove the last three lines from this file (line 47, line 48 and line 49) and leave the last line blank.

2. Paste the following code into the __main__ section of that script:

logger.info('Writing AppStream version.')
with open(path.join('build', 'debian', 'tribler', 'usr', 'share', 'metainfo',
                    'org.tribler.Tribler.metainfo.xml'), 'a') as f:
    f.write(f'    <release version="{version_id}" date="{build_date}"/>'
            f'\n  </releases>\n</component>')

[overflw]

Hey (: thanks for the hints! I wrote a xml parsing based addendum to update_version_from_git.py:

    logger.info('Writing AppStream version info.')
    releaseDate = time.strftime("%Y-%m-%d", time.localtime())
    attrib = {'version': f'{version_id}', 'date':f'{releaseDate}'}

    tree = xml.parse(path.join('build', 'debian', 'tribler', 'usr', 'share', 'metainfo',
                        'org.tribler.Tribler.metainfo.xml'))
    xmlRoot = tree.getroot()
    releases = xmlRoot.find('releases')
    release = xml.SubElement(releases, 'release', attrib)
    tree.write(path.join('build', 'debian', 'tribler', 'usr', 'share', 'metainfo',
                        'org.tribler.Tribler.metainfo.xml'))

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 3.971 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

[devos50]

Thanks for your changes! Could you look at/implement the suggestion raised by DeepCode? Also, please satisfy the flake8 check by making sure the import order is according to the standards 👍

[devos50]

Thanks for the changes! I just installed defusedxml on the machine that runs the flake8 checker. @xoriole do you think it is fine to add this as a build dependency or do you prefer to use the 'normal' XML parsing tools?

[overflw]

Thanks for the changes! I just installed defusedxml on the machine that runs the flake8 checker. @xoriole do you think it is fine to add this as a build dependency or do you prefer to use the 'normal' XML parsing tools?

Tbh, defusdxml is not really necessary here, since we only parse our own metainfo.xml. But it won't hurt I guess.

[xoriole]

@devos50 @overflw I'm fine with having it as a build dependency for Linux. I'd prefer it to be conditional import and the code for xml parsing and update to be under Linux section (Line 60).

[devos50]

retest this please

[xoriole]

retest this please

[overflw]

Hey, sorry for dismissing the review - I haven't seen it before pushing.. what can I do to close this pull request?

[devos50]

@overflw could you rebase and please squash your commit history into one commit (and remove the merge commits)?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[overflw]

@overflw could you rebase and please squash your commit history into one commit (and remove the merge commits)?

Should be done, I hope.

[qstokkink]

Failure on Mac is due to #6042:

Error Message

assert 59852 == 59850   +59852   -59850

Stacktrace

def test_get_first_free_port():
        # target port is free
        port = random.randint(50000, 60000)
>       assert get_first_free_port(start=port) == port
E       assert 59852 == 59850
E         +59852
E         -59850

src/tribler-core/tribler_core/tests/test_network_utils.py:56: AssertionError

This is a random failure, so retesting this PR should fix it.

[qstokkink]

retest this please

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[xoriole]

retest this please