Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to run Tribler with sentry URL for tests #5874

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Add an option to run Tribler with sentry URL for tests #5874

merged 1 commit into from
Dec 22, 2020

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Dec 22, 2020 •
edited
Loading

This PR is referred to #5857

It adds an option to run a Tribler client in test mode and send all the crash reports automatically.

To enable it you have to specify TEST_SENTRY_URL:

export TEST_SENTRY_URL=<some_url>

And enable crash reports auto-send in "triblerd.conf":

[error_handling]
error_reporting_requires_user_consent=False

@drew2a drew2a changed the title WIP Add an option to run Tribler with sentry URL for tests Add an option to run Tribler with sentry URL for tests Dec 22, 2020
@drew2a drew2a requested review from xoriole and kozlovsky December 22, 2020 11:40
xoriole
xoriole reviewed Dec 22, 2020
View reviewed changes
Copy link
Contributor

@xoriole xoriole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to enclose it into a function, the main would look cleaner

xoriole
xoriole previously approved these changes Dec 22, 2020
View reviewed changes
@drew2a drew2a force-pushed the feature/sentry_test_url branch from af54d20 to d665458 Compare December 22, 2020 12:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@drew2a drew2a merged commit 7562d25 into Tribler:devel Dec 22, 2020
@drew2a drew2a deleted the feature/sentry_test_url branch December 22, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

@xoriole xoriole xoriole left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drew2a @xoriole @kozlovsky