Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable market by default, added GUI toggle #5390

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Disable market by default, added GUI toggle #5390

merged 1 commit into from
Jun 18, 2020

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Jun 18, 2020

This PR disables the market by default and adds an option to the settings panel to enable it.

Fixes #5389

Schermafbeelding 2020-06-18 om 14 03 06

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devos50
Copy link
Contributor Author

devos50 commented Jun 18, 2020

Seems that one of the channel test hangs on Windows:

test_recursive_commit_channel_torrent (test_channel_metadata.TestChannelMetadata) ... + FAILURE=127

@devos50
Copy link
Contributor Author

devos50 commented Jun 18, 2020

retest this please

@devos50 devos50 marked this pull request as ready for review June 18, 2020 12:29
@devos50 devos50 requested a review from ichorid June 18, 2020 12:29
ichorid
ichorid approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@ichorid ichorid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ichorid ichorid merged commit fe7af88 into Tribler:release-7.5 Jun 18, 2020
@devos50 devos50 deleted the market_disable branch June 18, 2020 14:03
@devos50 devos50 linked an issue Jun 18, 2020 that may be closed by this pull request
Disable the market community by default + add toggle to settings menu #5389
Closed
@drew2a drew2a mentioned this pull request Jun 19, 2020
Closed
10 tasks
@ichorid ichorid mentioned this pull request Dec 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qstokkink qstokkink qstokkink approved these changes

@ichorid ichorid ichorid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable the market community by default + add toggle to settings menu
3 participants
@devos50 @ichorid @qstokkink