Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreditMining feature #5350

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Remove CreditMining feature #5350

merged 1 commit into from
Jun 3, 2020

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Jun 3, 2020

⌛ 💀 The time has come 💀 ⌛

@ichorid ichorid added this to the V7.5: core refactoring milestone Jun 3, 2020
@ichorid ichorid requested review from devos50 and egbertbouman June 3, 2020 12:10
@devos50
Copy link
Contributor

devos50 commented Jun 3, 2020

Even though I'm in favour of removing it, did we reach consensus on its removal?

@ichorid ichorid marked this pull request as ready for review June 3, 2020 12:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ichorid
Copy link
Contributor Author

ichorid commented Jun 3, 2020

Even though I'm in favour of removing it, did we reach consensus on its removal?

Considering @synctext himself put it in #5348, and he did not cross the thing as he sadly did with the proposed removal of the trust graph screen, I would say yes, we reached the consensus.

@devos50
Copy link
Contributor

devos50 commented Jun 3, 2020

Ah, I see. Didn't notice that the ticket has been updated.

@ichorid ichorid merged commit d31fe1c into Tribler:release-7.5 Jun 3, 2020
This was referenced Oct 21, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

@devos50 devos50 Awaiting requested review from devos50

Assignees
No one assigned
Labels
None yet
Milestone
V7.5: core refactoring
Development

Successfully merging this pull request may close these issues.
3 participants
@ichorid @devos50 @egbertbouman