Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load metainfo directly when unchecking 'anonymous' checkbox #5288

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Apr 12, 2020

When unchecking ☑️ "Download anonymously", trigger direct metainfo fetch, and vice-versa. Modify status label text accordingly to indicate in what mode the metainfo is being fetched currently.

Partially solves #4854

@ichorid ichorid added this to the V7.5: core refactoring milestone Apr 12, 2020
@ichorid ichorid requested a review from devos50 April 12, 2020 17:17
@ghost
Copy link

ghost commented Apr 12, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.109 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@devos50
Copy link
Contributor

devos50 commented Apr 12, 2020

retest this please

Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please cover the missing ValueError code, it should be quite easy do to so with a unit test.

@ichorid ichorid force-pushed the add_direct_metainfo branch from 2699412 to 55431c7 Compare April 12, 2020 18:20
@ichorid
Copy link
Contributor Author

ichorid commented Apr 12, 2020

Also, please cover the missing ValueError code, it should be quite easy do to so with a unit test.

Done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ichorid ichorid requested a review from devos50 April 12, 2020 18:38
@devos50 devos50 merged commit c4f45a5 into Tribler:release-7.5 Apr 12, 2020
@ichorid ichorid deleted the add_direct_metainfo branch April 12, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants