READY: Foreground DB upgrader #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichorid
force-pushed
the
f_offline_db_upgrade
branch
2 times, most recently
from
11c3a25 to
9160fd2
Compare
ichorid
force-pushed
the
f_offline_db_upgrade
branch
4 times, most recently
from
6420df6 to
dc89fb0
Compare
devos50
suggested changes
May 3, 2019
ichorid
force-pushed
the
f_offline_db_upgrade
branch
3 times, most recently
from
5767373 to
3334159
Compare
|
@ichorid don't forget to address this Pylint issue: |
ichorid
force-pushed
the
f_offline_db_upgrade
branch
from
3334159 to
0d6adfe
Compare
That's intentional. This is Pony's way of plugging in code on DB startup. I've added a comment on this. |
This commit makes DB upgrader from 72 to 73(Pony) run in foreground (at the "spinning gears" screen). "Skip" button is shown on the screen during the upgrading process. A corresponding dialog window REST endpoint are added, too. To speed up the upgrade process, disk synchronization is disabled. This is safe since we don't touch the original database.
ichorid
force-pushed
the
f_offline_db_upgrade
branch
from
0d6adfe to
89db424
Compare
qstokkink
approved these changes
May 15, 2019
xoriole
reviewed
May 15, 2019
| from Tribler.Test.tools import trial_timeout | ||
|
|
||
|
|
||
| class TestShutdownEndpoint(AbstractApiTest): |
There was a problem hiding this comment.
Please rename this endpoint and the docstring on the method test_upgrader_skip()
ichorid
force-pushed
the
f_offline_db_upgrade
branch
from
89db424 to
52a27ba
Compare
xoriole
reviewed
May 15, 2019
ichorid
force-pushed
the
f_offline_db_upgrade
branch
from
52a27ba to
8ccdda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves 72 -> 73(Pony) upgrader out of the background thread to be run in the foreground at Tribler startup instead.
This greatly speed-ups the process by as we can use larger batches and disable disk synchronization during the upgrade process for the newly created DB. This is safe to do, since the old DB is read-only, and the conversion process can always be started from a clean slate if power fails during the upgrade process.
Disabling sync makes the upgrade process run on an HDD as fast as on an SSD. On my machine, a 400Mb
tribler.sdbis converted in less than 1 minute.To give users some control over the process, a "skip" button along with a text indicator of the state of the upgrade process are added to the "spinning gears" screen. Pressing the button produces a confirmation dialog. Even if a user decides to skip the conversion process, their personal channel will still be converted.
Closes #4441
Closes #4439
Closes #4440