Refactored PopularityCommunity #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
reviewed
Mar 26, 2019
devos50
force-pushed
the
torrent_health_gossip
branch
from
799807a to
e271c84
Compare
devos50
force-pushed
the
torrent_health_gossip
branch
4 times, most recently
from
451d634 to
ebee697
Compare
|
I made a validation experiment to verify the correctness of the popularity community, see https://jenkins-ci.tribler.org/job/validation_experiments/job/validation_experiment_popularity/ |
xoriole
reviewed
Apr 3, 2019
| return | ||
| num_torrents_checked = len(self.torrent_checker.torrents_checked) | ||
| random_torrents_checked = random.sample(self.torrent_checker.torrents_checked, min(num_torrents_checked, 5)) | ||
| popular_torrents_checked = sorted(self.torrent_checker.torrents_checked, |
There was a problem hiding this comment.
Possibility of duplicate torrents for a small set?
devos50
force-pushed
the
torrent_health_gossip
branch
from
24b388b to
06a079b
Compare
xoriole
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I refactored the
PopularityCommunityand simplified it. In essence, it now gossips around at most 10 torrents. Five of these torrents are randomly selected torrents that you have checked (with at least one seeder). The other five torrents are the most healthy torrents that are health checked by you.Addresses #4256
Complements Tribler/gumby#409