Performing direct payouts to other Tribler clients #3776
Conversation
devos50
force-pushed
the
zero_hop_payout
branch
4 times, most recently
from
59bb192 to
dfda88e
Compare
devos50
force-pushed
the
zero_hop_payout
branch
3 times, most recently
from
e81c2e3 to
eb0fa0f
Compare
|
While I haven't finished the big experiment yet, I think this PR is ready for review 👍 |
| # this peer runs a Tribler instance | ||
| if self.state_cb_count % 5 == 0 and download.get_hops() == 0 and self.payout_manager: | ||
| for peer in download.get_peerlist(): | ||
| if 'Tribler' in peer["extended_version"]: |
There was a problem hiding this comment.
Can you do a .startswith() here? It is more efficient.
| if self.state_cb_count % 5 == 0 and download.get_hops() == 0 and self.payout_manager: | ||
| for peer in download.get_peerlist(): | ||
| if 'Tribler' in peer["extended_version"]: | ||
| self.payout_manager.update_peer(peer["id"].decode('hex'), infohash, peer["dtotal"]) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
The peer ID is already encoded in hex format: https://github.com/Tribler/tribler/blob/next/Tribler/Core/Libtorrent/LibtorrentDownloadImpl.py#L852
devos50
force-pushed
the
zero_hop_payout
branch
from
eb0fa0f to
877f832
Compare
devos50
force-pushed
the
zero_hop_payout
branch
from
6bf9f11 to
be926f8
Compare
devos50
force-pushed
the
zero_hop_payout
branch
from
c78f069 to
396ab47
Compare
|
Status update: it seems that the direct payouts is working correctly, however, I think there is a bug in the DHTDiscoveryCommunity since peers are removed after around one minute, even though they are pinged. Functional experiment (where I removed the (buggy?) code that deletes peers from the DHT storage): https://jenkins-ci.tribler.org/job/pers/job/direct_download_devos50/96/ Final interaction graph (not all peers are downloading something): Since this is not a bug specific to this PR, I consider this PR ready for merge and another review. I will discuss my observations with @egbertbouman tomorrow. |
devos50
force-pushed
the
zero_hop_payout
branch
from
396ab47 to
be926f8
Compare
devos50
changed the title
devos50
changed the title
This PR implements direct payouts between Tribler instances (zero-hop downloads).
TODO:
Fixes #3718