-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various bug fixes and improvements for the market #3502
Conversation
It was slowing down the anonymous downloads.
Please also include this in this PR: Make the session dispatching more efficient here: |
ERROR 1521022296 test_as_server:TestTunnelCommunity:124 The reactor was dirty during tearDown:
ERROR 1521022296 test_as_server:TestTunnelCommunity:126 > <DelayedCall 0x7f065a166758 [7.30270910263s] called=0 cancelled=0 RequestCache._on_timeout(<Tribler.pyipv8.ipv8.messaging.anonymization.caches.CreatedRequestCache object at 0x7f065a154f90>)> |
1c92591
to
93f1d08
Compare
d201629
to
0cbb5b4
Compare
@@ -240,7 +240,7 @@ def render_POST(self, request): | |||
|
|||
.. sourcecode:: none | |||
|
|||
curl -X GET http://localhost:8085/wallets/BTC/transfer | |||
curl -X POST http://localhost:8085/wallets/BTC/transfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docstring to replace get request with post
@@ -0,0 +1,36 @@ | |||
import json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the test is failing on this call, which is leaking a DelayedCall: self.register_task(cache, reactor.callLater(cache.timeout_delay, self._on_timeout, cache)) This might have to be a |
It leads to very high transaction consts for Bitcoin trading.
Improved logging in market community Fixed log message in matching engine
In this PR, I fixed some bugs in the market community. I also removed a log statement in the tunnel community that slowed anonymous downloads. I decided to have the improvement as suggested by @qstokkink in a separate PR since it did not work out of the box and this PR was growing quite a lot with fixes/improvements for the market community.
I also upgraded the Electrum wallet to 2.9.4 and tested some basic trading functionality between two different machines, with Testnet Bitcoin wallets.
Working market experiment with this PR: https://jenkins.tribler.org/job/pers/job/market_experiment_devos50/745/
Fixes #3494