Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new search relevance ranking algorithm #2415

Merged
merged 6 commits into from
Sep 11, 2016

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Jul 5, 2016

Fixes #2250

@devos50 devos50 force-pushed the search_ranking_refactor branch from 2727120 to affb5c5 Compare July 8, 2016 08:13
@devos50
Copy link
Contributor Author

devos50 commented Jul 8, 2016

@lfdversluis can you review? I will fix the import order error in the pylint after your review. Also, I think it's hard to reduce the number of local variables in the search_in_local_torrents_db methods (I'm not even sure how pylint counts them since my count results in a lower amount).

@@ -14,6 +15,8 @@
from traceback import print_exc
from collections import OrderedDict, defaultdict
from libtorrent import bencode

import math

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import order, was noted but just so you don't forget

@lfdversluis
Copy link

Comments given, Windows 64 bit is failing too.

@devos50 devos50 force-pushed the search_ranking_refactor branch from affb5c5 to 18b3910 Compare July 12, 2016 08:00
@devos50
Copy link
Contributor Author

devos50 commented Jul 12, 2016

Traceback (most recent call last):
  File "C:\Python27\lib\threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\Utilities\twisted_thread.py", line 55, in _reactor_runner
    reactor.run(installSignalHandlers=False)
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 1194, in run
    self.mainLoop()
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 1203, in mainLoop
    self.runUntilCurrent()
--- <exception caught here> ---
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 825, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\APIImplementation\threadpoolmanager.py", line 50, in caller
    fun(*args, **kwargs)
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\Libtorrent\LibtorrentMgr.py", line 482, in do_dht_check
    lt_session = self.get_session()
  File "C:\workspace\jenkins\workspace\GH_Tribler_PR_tests_win64\tribler\Tribler\Core\Libtorrent\LibtorrentMgr.py", line 186, in get_session
    if hops not in self.ltsessions:
exceptions.TypeError: argument of type 'NoneType' is not iterable

@devos50
Copy link
Contributor Author

devos50 commented Jul 12, 2016

retest this please

@devos50
Copy link
Contributor Author

devos50 commented Jul 12, 2016

@lfdversluis thanks for the review. I don't think the algorithm is perfect right now and it might need some minor tweaking but for now, I think it is ok for a first version of the GUI.

@devos50
Copy link
Contributor Author

devos50 commented Jul 12, 2016

@whirm ready for your review

@devos50 devos50 changed the title WIP: Implemented new search relevance ranking algorithm READY: Implemented new search relevance ranking algorithm Jul 12, 2016
@whirm
Copy link

whirm commented Jul 12, 2016

@devos50 is @synctext happy with the new algo?

@devos50
Copy link
Contributor Author

devos50 commented Jul 12, 2016

@whirm I will discuss it with him tomorrow.

@whirm
Copy link

whirm commented Jul 12, 2016

Ok, let me know about it

@whirm whirm changed the title READY: Implemented new search relevance ranking algorithm WIP: Implemented new search relevance ranking algorithm Jul 18, 2016
@whirm
Copy link

whirm commented Jul 18, 2016

Needs a rebase

@devos50
Copy link
Contributor Author

devos50 commented Jul 29, 2016

@synctext forgot to ask, can this be merged?

@devos50 devos50 force-pushed the search_ranking_refactor branch from 18b3910 to ff2774a Compare August 1, 2016 07:50
@devos50
Copy link
Contributor Author

devos50 commented Sep 11, 2016

Let's see how this algorithm works out. Any improvements to the algorithm can be made later 👍

@devos50 devos50 changed the title WIP: Implemented new search relevance ranking algorithm Implemented new search relevance ranking algorithm Sep 11, 2016
@devos50 devos50 merged commit 4bd52fa into Tribler:devel Sep 11, 2016
@devos50 devos50 deleted the search_ranking_refactor branch September 11, 2016 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants