-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented new search relevance ranking algorithm #2415
Conversation
2727120
to
affb5c5
Compare
@lfdversluis can you review? I will fix the import order error in the pylint after your review. Also, I think it's hard to reduce the number of local variables in the |
@@ -14,6 +15,8 @@ | |||
from traceback import print_exc | |||
from collections import OrderedDict, defaultdict | |||
from libtorrent import bencode | |||
|
|||
import math |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import order, was noted but just so you don't forget
Comments given, Windows 64 bit is failing too. |
affb5c5
to
18b3910
Compare
|
retest this please |
@lfdversluis thanks for the review. I don't think the algorithm is perfect right now and it might need some minor tweaking but for now, I think it is ok for a first version of the GUI. |
@whirm ready for your review |
@whirm I will discuss it with him tomorrow. |
Ok, let me know about it |
Needs a rebase |
@synctext forgot to ask, can this be merged? |
18b3910
to
ff2774a
Compare
Let's see how this algorithm works out. Any improvements to the algorithm can be made later 👍 |
Fixes #2250